Wait until after peer relation joined before acquiring lock #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
requested review from
juditnovak,
phvalguima and
Mehdi-Bendriss
Mehdi-Bendriss
previously approved these changes
Apr 30, 2024
carlcsaposs-canonical
force-pushed
the
fix-lock-startup
branch
2 times, most recently
from
95ff97e
to
3012f35
Compare
## Issue During initial startup (i.e. scale-up), a unit will request a lock via the peer databag until it gets a peer-relation-joined event and learns that other units of OpenSearch are online ## Solution Wait until after the first peer-relation-joined event before trying to acquire lock (so that if [enough] units of opensearch are online, we request the opensearch lock instead of peer databag lock)
This reverts commit 34a766e.
carlcsaposs-canonical
force-pushed
the
fix-lock-startup
branch
from
cd45bb0
to
04d0c44
Compare
Mehdi-Bendriss
previously approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
During initial startup (i.e. scale-up), a unit will request a lock via the peer databag until it gets a peer-relation-joined event and learns that other units of OpenSearch are online
Solution
Wait until after the first peer-relation-joined event before trying to acquire lock (so that if [enough] units of opensearch are online, we request the opensearch lock instead of peer databag lock)